Skip to content

Tta 87 create secrets management for time tracker v 2 and time tracker UI#901

Merged
rodolfoIOET merged 41 commits into
masterfrom
TTA-87-create-secrets-management-for-time-tracker-v-2-and-time-tracker-ui
Jul 18, 2022
Merged

Tta 87 create secrets management for time tracker v 2 and time tracker UI#901
rodolfoIOET merged 41 commits into
masterfrom
TTA-87-create-secrets-management-for-time-tracker-v-2-and-time-tracker-ui

Conversation

@rodolfoIOET
Copy link
Copy Markdown
Contributor

@rodolfoIOET rodolfoIOET commented Jul 11, 2022

No description provided.

Marco Aguirre and others added 30 commits July 6, 2022 16:53
Innecesary env files deleted
cd6a676
New changes to env files
9dd2d22
Merge from master
5cd8097
Add 1 git-crypt collaborator
cee7a67 
New collaborators:

	F295BDD1 Marco Aguirre <marco.aguirre@ioet.com>
Add 1 git-crypt collaborator
37395a4 
New collaborators:

	1CC2872D Rodolfo Diaz <rodolfo.diaz@ioet.com>
Add 2 git-crypt collaborators
64715d8 
New collaborators:

	1CC2872D Rodolfo Diaz <rodolfo.diaz@ioet.com>
	F295BDD1 Marco Aguirre <marco.aguirre@ioet.com>
New keys and env variables added
04b36bf
env files added & modified
46713de
Merge from master
3cbea5e
Make run now uses .dev.env
dd2e28c
Pipeline modified
5fbd76a
@rodolfoIOET
is the .env needed?
417fb0f
@rodolfoIOET
using encrypted .stage.env
f98d359
@rodolfoIOET
load secrets
d829238
@rodolfoIOET
adding env variables
f304803
@rodolfoIOET
scopes cannot be empty
d798597
@rodolfoIOET
use env
71b814c
@rodolfoIOET
using env var
e0557f3
@rodolfoIOET
using env file
09204b3
@rodolfoIOET
adding mask
eaa95fe
@rodolfoIOET
using docker buildkit
38b3cd8
@rodolfoIOET
only on tags
c9a8046
@rodolfoIOET
using buildkit directly
ac78df4
@rodolfoIOET
using dash source
9f8f2f3
@rodolfoIOET
docker buildkit
4f78988
@rodolfoIOET
missing folders added
c6ab1b4
@rodolfoIOET
nginx fix
82f58a6
@rodolfoIOET
fixing secrets
0b5f089
@rodolfoIOET
problem with double qoutes
59dbb51
@rodolfoIOET
fixing quotes in .stage.env
6506028
PVioet
PVioet approved these changes Jul 12, 2022
View reviewed changes
Copy link
Copy Markdown

@PVioet PVioet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is lacking a white space of the end of package.json and total-hours-report.ts, everything else looks good

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 18, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
25.0% 25.0% Duplication

@rodolfoIOET rodolfoIOET merged commit dfb2ae1 into master Jul 18, 2022
@rodolfoIOET rodolfoIOET deleted the TTA-87-create-secrets-management-for-time-tracker-v-2-and-time-tracker-ui branch July 18, 2022 15:23
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 18, 2022

[infrastructure/][stage] Terraform Plan 📖 success

Show Plan ```

terraform
module.ui.azurerm_app_service_plan.plan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/serverfarms/time-tracker-ui-stage]
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/TXT/asuid.ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/CNAME/ui]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be updated in-place

~ resource "azurerm_app_service" "this" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @rodolfoIOET, Action: `pull_request`*

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 18, 2022

[infrastructure/][prod] Terraform Plan 📖 success

Show Plan ```

terraform

</details>
*Pusher: @rodolfoIOET, Action: `pull_request`*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@reihtw reihtw reihtw approved these changes

@PVioet PVioet PVioet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rodolfoIOET @reihtw @PVioet